-
Notifications
You must be signed in to change notification settings - Fork 9
WIP: Version 1.0.0 #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except the CKAN ones because those are self-evident
makes debugging way easier in Rider
This means that everything can be set in .csproj.user without hacks
# Conflicts: # CHANGELOG.md
allows for skipping installation entirely, as well as supporting non-debian-based operating systems in the future.
### Msbuild
- Renamed global msbuild properties to have the `KSPBT_` prefix to avoid namespace collisions with other frameworks
- `KSPRoot` is now `KSPBT_GameRoot`. It should no longer be referenced within a .csproj file
- `RepoRootPath` is now `KSPBT_ModRoot`, and should now point to the mod folder within GameData rather than the
root of a git repo
- `BinariesOutputRelativePath` is now `KSPBT_ModPluginFolder`
- `GenerateKSPAssemblyAttribute` is now `KSPBT_GenerateAssemblyAttribute` and defaults to true
- `GenerateKSPAssemblyDependencyAttributes` is now `KSPBT_GenerateDependencyAttributes` and defaults to true
- `ReferenceUnityAssemblies` is now `KSPBT_ReferenceUnityAssemblies`
- `ReferenceKSPAssemblies` is now `KSPBT_ReferenceGameAssemblies`
- Added the `KSPBT_ReferenceSystemAssemblies` property to control referencing the mono system DLLs within the KSP
managed folder. Setting this property to false will load the implicit framework DLLs instead.
- Mod dependencies should now be declared with
`ModReference` items. This avoids the need for the KSP install path to be known at evaluation time.
- Only include Log.cs (or anything else in include/unity) when `KSPBT_ReferenceUnityAssemblies` is `true` (#61)
- Fix `KSP_VERSION_MAX` getting mangled when using an existing version file (#64)
- Fix incorrect behavior when building without a solution (#50)
### Actions
- KSPBT actions used in reusable workflows are now pinned with each tag, instead of using actions from `main`. All calls to reusable workflows should be pinned to a tag to ensure the correct actions are being used. (#21)
- `compile` action: Use `dotnet restore` instead of `nuget restore` by default, allowing the action to work on any Ubuntu runner image. Added the `use-nuget-restore` option to restore the previous behavior for projects that use packages.config for dependencies. (#68)
- `compile` action: Removed call to`actions/setup-dotnet`. Setting up .NET should be done as a separate step. (#65)
- `setup-ckan` action: Sped up execution by skipping recommended packages and man-db updates
- `setup-ckan` action: Add `ckan-install-method` option for installation method. Currently supports `'apt'` for installation on Debian/Ubuntu, or `'skip'` to skip installation for runners that already have CKAN installed.
- `assemble-release` action: `outputs.artifact-path` now includes the `.zip` extension (#51)
as well as changing its outputs
…se in futility FSF Delende Est
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change (so the version would change to 1.0.0).
Docs build for this branch: https://kspbuildtools.readthedocs.io/en/next/
The goals here were:
Changelog:
Msbuild
KSPBT_prefix to avoid namespace collisions with other frameworksKSPRootis nowKSPBT_GameRoot. It should no longer be referenced within a .csproj fileRepoRootPathis nowKSPBT_ModRoot, and should now point to the mod folder within GameData rather than theroot of a git repo
BinariesOutputRelativePathis nowKSPBT_ModPluginFolderGenerateKSPAssemblyAttributeis nowKSPBT_GenerateAssemblyAttributeand defaults to trueGenerateKSPAssemblyDependencyAttributesis nowKSPBT_GenerateDependencyAttributesand defaults to trueReferenceUnityAssembliesis nowKSPBT_ReferenceUnityAssembliesReferenceKSPAssembliesis nowKSPBT_ReferenceGameAssembliesKSPBT_ReferenceSystemAssembliesproperty to control referencing the mono system DLLs within the KSPmanaged folder. Setting this property to false will load the implicit framework DLLs instead.
ModReferenceitems. This avoids the need for the KSP install path to be known at evaluation time.KSP_VERSION_MAXgetting mangled when using an existing version file (Version file generation is adding extra single quotes on KSP_Version_Max #64)Actions
main. All calls to reusable workflows should be pinned to a tag to ensure the correct actions are being used. (Find a way to pin workflow/action versions #21)compileaction: Usedotnet restoreinstead ofnuget restoreby default, allowing the action to work on any Ubuntu runner image. Added theuse-nuget-restoreoption to restore the previous behavior for projects that use packages.config for dependencies. (Re-enable support for packages.config style projects innext#68)compileaction: Removed call toactions/setup-dotnet. Setting up .NET should be done as a separate step. (Proposal: Drop setup-dotnet from compile action #65)setup-ckanaction: Sped up execution by skipping recommended packages and man-db updatessetup-ckanaction: Addckan-install-methodoption for installation method. Currently supports'apt'for installation on Debian/Ubuntu, or'skip'to skip installation for runners that already have CKAN installed.assemble-releaseaction:outputs.artifact-pathwas split intooutputs.artifact-zip-pathandoutputs.artifact-dir-pathcontaining paths to a zip file and directory respectively. These are also now located under$RELEASE_STAGINGinstead of inside the workspaceassemble-releaseaction: Removed call toactions/upload-artifact. This should be done as a separate step.Library